Header height issue...

BB Theme
21

So far, so good, Justin. Is this a CSS fix?

22

Great! It is a JS fix to the js/theme.js file. Specifically, this code…

_initRetinaImages: function()
{
	var pixelRatio = !!window.devicePixelRatio ? window.devicePixelRatio : 1;

    if ( pixelRatio > 1 ) {
        $( 'img[data-retina]' ).each( function() {
            if ( '' != $( this ).data( 'retina' ) ) {              
                if ( this.complete ) {
                    FLTheme._convertImageToRetina.apply( this );
                }
                else {
                    $( this ).on( 'load', FLTheme._convertImageToRetina );
                }
            }
        });
    }
},

_convertImageToRetina: function()
{
	var image       = $( this ),
	    src         = image.attr( 'src' ),
	    retinaSrc   = image.data( 'retina' ),
	    height		= image.height(),
	    width		= image.width();
	    
    image.height( height );
    image.width( width );
    image.attr( 'src', retinaSrc );
}

The was an intermittent loading issue that was throwing off the width/height calculations. I believe that was due to browser caching.

Justin

23

Very cool. Glad it’s fixed.
You guys have a great product :slight_smile: